Re: [PATCH net-next v2] net: micrel: Add support for lan8841 PHY

[Andrew Lunn]

On Fri, Feb 03, 2023 at 04:25:48PM +0100, Horatiu Vultur wrote:
> The 02/03/2023 15:22, Andrew Lunn wrote:
> 
> Hi Andrew,
> 
> > 
> > > +{
> > > +     char *rx_data_skews[4] = {"rxd0-skew-psec", "rxd1-skew-psec",
> > > +                               "rxd2-skew-psec", "rxd3-skew-psec"};
> > > +     char *tx_data_skews[4] = {"txd0-skew-psec", "txd1-skew-psec",
> > > +                               "txd2-skew-psec", "txd3-skew-psec"};
> > 
> > Please take a read of
> > Documentation/devicetree/bindings/net/micrel-ksz90x1.txt and then add
> > a section which describes what these properties mean for this PHY,
> > since nearly every microchip PHY has a different meaning :-(
> 
> I had a closer look at the datasheet of this PHY, and these properties
> for lan8841 are the same for ksz9131, so actually I can reuse the
> function 'ksz9131_config_init', to remove some of the duplicated code.

Great.

> In this case maybe is enough to add the following change in
> 'micrel-ksz90x1.txt' not to create a totally new section.
> 
>  KSZ9131:
> +LAN8841:

Yes, that is good, and KSZ9131 is about the only one which actually
gets this right, so it is a good you can reuse it.

     Andrew