Re: [PATCH v4 1/2] dt-bindings: leds-lp55xx: add ti,charge-pump-mode

[Maarten Zanders]

On 2/2/23 21:13, Krzysztof Kozlowski wrote:
> + ti,charge-pump-mode:
> > +    description:
> > +      Set the operating mode of the internal charge pump as defined in
> > +      <dt-bindings/leds/leds-lp55xx.h>. Defaults to auto.
> > +    $ref: /schemas/types.yaml#/definitions/uint8
> This should be then uint32

Why is that? I specifically chose uint8 because other settings for LED 
are also uint8. The implementation is also uint8. I surely hope we'll 
never get to >256 modes for a charge pump.


> default: 3
> (and drop last sentence about default)
OK
> +/* SPDX-License-Identifier: GPL-2.0 */
> Dual license.

OK

Best regards,
Maarten