Re: [PATCH V2] dt-bindings: usb: snps,dwc3: support i.MX8MQ

From: Rob Herring
Date: Fri Feb 03 2023 - 08:52:29 EST



On Fri, 03 Feb 2023 09:45:26 +0800, Peng Fan (OSS) wrote:
> From: Peng Fan <peng.fan@xxxxxxx>
>
> i.MX8MQ use Synopsys DesignWare USB3 Controller IP, so add the
> compatible.
>
> Signed-off-by: Peng Fan <peng.fan@xxxxxxx>
> ---
>
> V2:
> Rebased on linux-next, remove power-domains from v1
>
> Documentation/devicetree/bindings/usb/snps,dwc3.yaml | 12 +++++++-----
> 1 file changed, 7 insertions(+), 5 deletions(-)
>

My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
on your patch (DT_CHECKER_FLAGS is new in v5.13):

yamllint warnings/errors:

dtschema/dtc warnings/errors:
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/usb/rockchip,dwc3.example.dtb: usb@fe800000: compatible: 'oneOf' conditional failed, one must be fixed:
['rockchip,rk3399-dwc3', 'snps,dwc3'] is too long
'fsl,imx8mq-dwc3' was expected
'snps,dwc3' was expected
'synopsys,dwc3' was expected
From schema: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/usb/snps,dwc3.yaml
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/usb/rockchip,dwc3.example.dtb: usb@fe800000: Unevaluated properties are not allowed ('compatible' was unexpected)
From schema: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/usb/snps,dwc3.yaml
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/usb/rockchip,dwc3.example.dtb: usb@fe800000: compatible: 'oneOf' conditional failed, one must be fixed:
['rockchip,rk3399-dwc3', 'snps,dwc3'] is too long
'fsl,imx8mq-dwc3' was expected
'snps,dwc3' was expected
'synopsys,dwc3' was expected
From schema: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/usb/rockchip,dwc3.yaml
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/usb/rockchip,dwc3.example.dtb: usb@fe800000: Unevaluated properties are not allowed ('compatible' was unexpected)
From schema: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/usb/rockchip,dwc3.yaml
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/usb/rockchip,dwc3.example.dtb: usb@fe800000: Unevaluated properties are not allowed ('dr_mode' was unexpected)
From schema: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/usb/rockchip,dwc3.yaml

doc reference errors (make refcheckdocs):

See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20230203014526.1461386-1-peng.fan@xxxxxxxxxxx

The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.