Re: [syzbot] WARNING: locking bug in umh_complete

[Tetsuo Handa]

On 2023/02/03 21:30, Peter Zijlstra wrote:
>> I think the right fix is to:
>>
>> 	state &= ~TASK_KILLABLE;
> 
> 	state &= ~__TASK_WAKEKILL;
> 
> we don't want to mask out UNINTERUPTIBLE, that would be bad.

This code was made killable as a solution for CVE-2012-4398.
Although OOM reaper is available today, making back to unkillable is not smart.

> 
>> 	wait_for_completion_state(&done, state);
>>
>> Also, put in a comment..