Re: [PATCH v4 3/8] dt-bindings: phy: qcom,qmp-usb: Document SM8550 compatible

From: Johan Hovold
Date: Fri Feb 03 2023 - 05:37:53 EST


On Thu, Feb 02, 2023 at 03:25:06PM +0200, Abel Vesa wrote:
> Add the SM8550 compatible to the list.
>
> Signed-off-by: Abel Vesa <abel.vesa@xxxxxxxxxx>
> Acked-by: Rob Herring <robh@xxxxxxxxxx>
> ---
>
> The v3 version of this patch was here:
> https://lore.kernel.org/all/20230126131415.1453741-4-abel.vesa@xxxxxxxxxx/
>
> Changes since v3:
> * added Rob's A-b tag
>
> Changes since v2:
> * none
>
> Changes since v1:
> * moved to sc8280xp bindings
>
> .../devicetree/bindings/phy/qcom,sc8280xp-qmp-usb43dp-phy.yaml | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/Documentation/devicetree/bindings/phy/qcom,sc8280xp-qmp-usb43dp-phy.yaml b/Documentation/devicetree/bindings/phy/qcom,sc8280xp-qmp-usb43dp-phy.yaml
> index 6f31693d9868..ec00fbc06abe 100644
> --- a/Documentation/devicetree/bindings/phy/qcom,sc8280xp-qmp-usb43dp-phy.yaml
> +++ b/Documentation/devicetree/bindings/phy/qcom,sc8280xp-qmp-usb43dp-phy.yaml
> @@ -17,6 +17,7 @@ properties:
> compatible:
> enum:
> - qcom,sc8280xp-qmp-usb43dp-phy
> + - qcom,sm8550-qmp-usb3-dp-phy
>
> reg:
> maxItems: 1

Subject prefix should be

dt-bindings: phy: qcom,sc8280xp-qmp-usb43dp:

Looks good otherwise:

Reviewed-by: Johan Hovold <johan+linaro@xxxxxxxxxx>