Re: [RFC PATCH 1/4] virtio_pci: add a definition of queue flag in ISR

From: Michael S. Tsirkin
Date: Fri Feb 03 2023 - 05:18:59 EST


On Fri, Feb 03, 2023 at 07:04:15PM +0900, Shunsuke Mie wrote:
> Already it has beed defined a config changed flag of ISR, but not the queue
> flag. Add a macro for it.
>
> Signed-off-by: Shunsuke Mie <mie@xxxxxxxxxx>
> Signed-off-by: Takanari Hayama <taki@xxxxxxxxxx>
> ---
> include/uapi/linux/virtio_pci.h | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/include/uapi/linux/virtio_pci.h b/include/uapi/linux/virtio_pci.h
> index f703afc7ad31..fa82afd6171a 100644
> --- a/include/uapi/linux/virtio_pci.h
> +++ b/include/uapi/linux/virtio_pci.h
> @@ -94,6 +94,8 @@
>
> #endif /* VIRTIO_PCI_NO_LEGACY */
>
> +/* Ths bit of the ISR which indicates a queue entry update */

typo

Something to add here:
Note: only when MSI-X is disabled



> +#define VIRTIO_PCI_ISR_QUEUE 0x1
> /* The bit of the ISR which indicates a device configuration change. */
> #define VIRTIO_PCI_ISR_CONFIG 0x2
> /* Vector value used to disable MSI for queue */
> --
> 2.25.1