Re: [PATCH v2] iommu: dart: DART_T8110_ERROR range should be 0 to 5

[Joerg Roedel]

On Wed, Feb 01, 2023 at 12:42:58PM +0000, Eric Curtin wrote:
> This was detected by smatch as one "else if" statement could never be
> reached. Confirmed bit order by comparing with python implementation [1].
> 
> drivers/iommu/apple-dart.c:991 apple_dart_t8110_irq()
> warn: duplicate check 'error_code == ((((1))) << (3))'
>   (previous on line 989)
> 
> Link: https://github.com/AsahiLinux/m1n1/commit/96b2d584feec1e3f7bfa [1]
> 
> Fixes: d8bcc870d99d ("iommu: dart: Add t8110 DART support")
> Reported-by: Dan Carpenter <error27@xxxxxxxxx>
> Signed-off-by: Eric Curtin <ecurtin@xxxxxxxxxx
                                   Missing char ^

Fixed that and applied the patch, thanks. Please use checkpatch next
time.

Regards,

	Joerg