Re: [PATCH 3/3] erofs: call erofs_map_dev() inside erofs_map_blocks()

From: Jingbo Xu
Date: Fri Feb 03 2023 - 00:55:56 EST




On 2/3/23 1:52 PM, Gao Xiang wrote:
>
>
> On 2023/2/3 11:53, Jingbo Xu wrote:
>> For now erofs_map_blocks() is always followed by erofs_map_dev().
>> Make erofs_map_dev() called inside erofs_map_blocks() to reduce code
>> duplication.
>
> Could we just integrate mdev into struct erofs_map_blocks?

Okay I will give it a try.


>
> BTW, I still think erofs_map_dev() is useful since it can handle
> non-inode IO requests, so let's keep this rather than mergeing all
> code into erofs_map_blocks()

Yeah erofs_map_dev() is kept as a separated function API.


--
Thanks,
Jingbo