Re: [PATCH 0/6] features provisioning fixes and mlx5_vdpa support

[Si-Wei Liu]

On 2/2/2023 9:30 AM, Michael S. Tsirkin wrote:
> On Tue, Jan 31, 2023 at 03:22:01PM -0800, Si-Wei Liu wrote:
> > This patchset is pre-requisite to export and provision device
> > config attributes and features for vdpa live migration, in a way
> > backward and forward compatibility can be retained. The follow up
> > work [1] will need to be built around the new feature provisioning
> > uAPI, with which it's easier to formalize migration compatibility
> > support at the driver level.
> >
> > Thanks,
> > -Siwei
> >
> > [1] [PATCH v3 0/4] vDPA: initial config export via "vdpa dev show"
> > https://lore.kernel.org/virtualization/1666392237-4042-1-git-send-email-si-wei.liu@xxxxxxxxxx/
> 1-6 look like bugfixes right?
1 and 2 are bug fixes, 3-5 you can say are bug fix for device_features, 
but they would lay the ground for standardizing device_features 
assumptions for drivers. Patch 6 is adding device_features to mlx5_vdpa 
as you can recognize.

(please match the corresponding patch in the v2 series)

Thanks,
-Siwei

> > ---
> >
> > Si-Wei Liu (6):
> >    vdpa: fix improper error message when adding vdpa dev
> >    vdpa: conditionally read STATUS in config space
> >    vdpa: validate provisioned device features against specified attribute
> >    virtio: VIRTIO_DEVICE_F_MASK for all per-device features
> >    vdpa: validate device feature provisioning against supported class
> >    vdpa/mlx5: support device features provisioning
> >
> >   drivers/vdpa/mlx5/net/mlx5_vnet.c  | 72 ++++++++++++++++++++++------
> >   drivers/vdpa/vdpa.c                | 98 ++++++++++++++++++++++++++++++++------
> >   include/uapi/linux/virtio_config.h |  8 ++++
> >   3 files changed, 149 insertions(+), 29 deletions(-)
> >
> > --
> > 1.8.3.1