Re: [PATCH 3/3] thermal/drivers/intel: Use generic trip points for intel_soc_dts_iosf

[Daniel Lezcano]

On 02/02/2023 15:43, Rafael J. Wysocki wrote:
> On Thu, Feb 2, 2023 at 3:36 PM Daniel Lezcano <daniel.lezcano@xxxxxxxxxx> wrote:
> > Hi Rafael,
> >
> > On 31/01/2023 20:17, Rafael J. Wysocki wrote:
> >
> > [ ... ]
> >
> > > > > Why should temp be overwritten here?
> > > >
> > > > You are correct. This is wrong.
> > > >
> > > > I think we should call get_trip_temp() before calling update_trip_temp()
> > > > instead of passing a zero temperature parameter
> > >
> > > update_trip_temp() is sort of a misnomer, because it is used for
> > > initializing a trip point for example in
> > > intel_soc_dts_iosf_add_read_only_critical_trip() and in this
> > > particular case get_trip_temp() need not be called before it.
> > >
> > > This driver seems to be in need of a cleanup.
> >
> > Will you take care of this cleanup ?
>
> I think I can do that, but I'm not sure how much time I will be able
> to allocate for that.  Let me try though.

Great, thanks for your help


--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog