Re: [v1 3/3] drm/msm/disp/dpu1: reserve the resources on topology change
From: kernel test robot
Date: Thu Feb 02 2023 - 09:10:00 EST
Hi Kalyan,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on drm-misc/drm-misc-next]
[also build test ERROR on drm/drm-next drm-exynos/exynos-drm-next drm-intel/for-linux-next drm-intel/for-linux-next-fixes drm-tip/drm-tip linus/master v6.2-rc6]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Kalyan-Thota/drm-msm-disp-dpu1-clear-dspp-reservations-in-rm-release/20230130-232224
base: git://anongit.freedesktop.org/drm/drm-misc drm-misc-next
patch link: https://lore.kernel.org/r/1675092092-26412-4-git-send-email-quic_kalyant%40quicinc.com
patch subject: [v1 3/3] drm/msm/disp/dpu1: reserve the resources on topology change
config: arm64-randconfig-r034-20230129 (https://download.01.org/0day-ci/archive/20230202/202302022254.37XyfGnR-lkp@xxxxxxxxx/config)
compiler: aarch64-linux-gcc (GCC) 12.1.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/intel-lab-lkp/linux/commit/4c49c3233fc18f3b746a96b5ff4ce5008da3bfec
git remote add linux-review https://github.com/intel-lab-lkp/linux
git fetch --no-tags linux-review Kalyan-Thota/drm-msm-disp-dpu1-clear-dspp-reservations-in-rm-release/20230130-232224
git checkout 4c49c3233fc18f3b746a96b5ff4ce5008da3bfec
# save the config file
mkdir build_dir && cp config build_dir/.config
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=arm64 olddefconfig
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=arm64 SHELL=/bin/bash drivers/gpu/
If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@xxxxxxxxx>
All errors (new ones prefixed by >>):
>> drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c:2091:6: error: conflicting types for 'dpu_encoder_prepare_commit'; have 'void(struct drm_encoder *)'
2091 | void dpu_encoder_prepare_commit(struct drm_encoder *drm_enc)
| ^~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys.h:19,
from drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c:29:
drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.h:155:6: note: previous declaration of 'dpu_encoder_prepare_commit' with type 'void(struct drm_encoder *, struct drm_crtc_state *)'
155 | void dpu_encoder_prepare_commit(struct drm_encoder *drm_enc,
| ^~~~~~~~~~~~~~~~~~~~~~~~~~
--
drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c: In function 'dpu_kms_prepare_commit':
>> drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c:443:25: error: too few arguments to function 'dpu_encoder_prepare_commit'
443 | dpu_encoder_prepare_commit(encoder);
| ^~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c:30:
drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.h:155:6: note: declared here
155 | void dpu_encoder_prepare_commit(struct drm_encoder *drm_enc,
| ^~~~~~~~~~~~~~~~~~~~~~~~~~
vim +2091 drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c
ae4d721ce10057 Abhinav Kumar 2022-04-26 2090
25fdd5933e4c0f Jeykumar Sankaran 2018-06-27 @2091 void dpu_encoder_prepare_commit(struct drm_encoder *drm_enc)
25fdd5933e4c0f Jeykumar Sankaran 2018-06-27 2092 {
25fdd5933e4c0f Jeykumar Sankaran 2018-06-27 2093 struct dpu_encoder_virt *dpu_enc;
25fdd5933e4c0f Jeykumar Sankaran 2018-06-27 2094 struct dpu_encoder_phys *phys;
25fdd5933e4c0f Jeykumar Sankaran 2018-06-27 2095 int i;
25fdd5933e4c0f Jeykumar Sankaran 2018-06-27 2096
25fdd5933e4c0f Jeykumar Sankaran 2018-06-27 2097 if (!drm_enc) {
25fdd5933e4c0f Jeykumar Sankaran 2018-06-27 2098 DPU_ERROR("invalid encoder\n");
25fdd5933e4c0f Jeykumar Sankaran 2018-06-27 2099 return;
25fdd5933e4c0f Jeykumar Sankaran 2018-06-27 2100 }
25fdd5933e4c0f Jeykumar Sankaran 2018-06-27 2101 dpu_enc = to_dpu_encoder_virt(drm_enc);
25fdd5933e4c0f Jeykumar Sankaran 2018-06-27 2102
25fdd5933e4c0f Jeykumar Sankaran 2018-06-27 2103 for (i = 0; i < dpu_enc->num_phys_encs; i++) {
25fdd5933e4c0f Jeykumar Sankaran 2018-06-27 2104 phys = dpu_enc->phys_encs[i];
b6fadcade62704 Drew Davenport 2019-12-06 2105 if (phys->ops.prepare_commit)
25fdd5933e4c0f Jeykumar Sankaran 2018-06-27 2106 phys->ops.prepare_commit(phys);
25fdd5933e4c0f Jeykumar Sankaran 2018-06-27 2107 }
25fdd5933e4c0f Jeykumar Sankaran 2018-06-27 2108 }
25fdd5933e4c0f Jeykumar Sankaran 2018-06-27 2109
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests