Re: [PATCH net] net: page_pool: use in_softirq() instead

From: Leon Romanovsky
Date: Thu Feb 02 2023 - 03:59:27 EST


On Thu, Feb 02, 2023 at 10:44:17AM +0800, Qingfang DENG wrote:
> From: Qingfang DENG <qingfang.deng@xxxxxxxxxxxxxxx>
>
> We use BH context only for synchronization, so we don't care if it's
> actually serving softirq or not.
>
> As a side node, in case of threaded NAPI, in_serving_softirq() will
> return false because it's in process context with BH off, making
> page_pool_recycle_in_cache() unreachable.
>
> Signed-off-by: Qingfang DENG <qingfang.deng@xxxxxxxxxxxxxxx>
> Fixes: 7886244736a4 ("net: page_pool: Add bulk support for ptr_ring")
> Fixes: ff7d6b27f894 ("page_pool: refurbish version of page_pool code")

Please put your Signed-off-by after Fixes.

Thanks