Re: [PATCH RFC v7 11/64] KVM: SEV: Support private pages in LAUNCH_UPDATE_DATA

[Nikunj A. Dadhania]

On 01/02/23 23:52, Borislav Petkov wrote:
> On Wed, Dec 14, 2022 at 01:40:03PM -0600, Michael Roth wrote:
>> From: Nikunj A Dadhania <nikunj@xxxxxxx>
>>
>> Pre-boot guest payload needs to be encrypted and VMM has copied it
> 
> "has to have copied it over" I presume?

True, payload is being copied in patch 10/64 now.
 
>> over to the private-fd. Add support to get the pfn from the memfile fd
>> for encrypting the payload in-place.
> 
> Why is that a good thing?
> 
> I guess with UPM you're supposed to get the PFN of that encrypted guest
> payload from that memslot.
> 
> IOW, such commit messages are too laconic for my taste and you could try
> to explain more why this is happening instead of me having to
> "reverse-deduce" what you're doing from the code...
> 

I am updating the SEV related patches, will add more details in commit and send.

Regards
Nikunj