Re: [PATCH] usb: gadget: udc: do not clear gadget driver.bus

From: Alan Stern
Date: Wed Feb 01 2023 - 20:28:52 EST


On Thu, Feb 02, 2023 at 12:01:25AM +0200, Aaro Koskinen wrote:
> Before the commit fc274c1e9973 ("USB: gadget: Add a new bus for gadgets")
> gadget driver.bus was unused. For whatever reason, many UDC drivers set
> this field explicitly to NULL in udc_start(). With the newly added gadget
> bus, doing this will crash the driver during the attach.
>
> The problem was first reported, fixed and tested with OMAP UDC and g_ether.
> Other drivers are changed based on code analysis only.
>
> Fixes: fc274c1e9973 ("USB: gadget: Add a new bus for gadgets")
> Signed-off-by: Aaro Koskinen <aaro.koskinen@xxxxxx>
> ---

Acked-by: Alan Stern <stern@xxxxxxxxxxxxxxxxxxx>