Re: [PATCH v3] powerpc: macio: Make remove callback of macio driver void returned

From: Damien Le Moal
Date: Wed Feb 01 2023 - 16:06:42 EST


On 2/1/23 23:36, Dawei Li wrote:
> Commit fc7a6209d571 ("bus: Make remove callback return void") forces
> bus_type::remove be void-returned, it doesn't make much sense for any
> bus based driver implementing remove callbalk to return non-void to
> its caller.
>
> This change is for macio bus based drivers.
>
> Signed-off-by: Dawei Li <set_pte_at@xxxxxxxxxxx>
> ---
> v2 -> v3
> - Rebased on latest powerpc/next.
> - cc' to relevant subsysem lists.
>
> v1 -> v2
> - Revert unneeded changes.
> - Rebased on latest powerpc/next.
>
> v1
> - https://lore.kernel.org/all/TYCP286MB2323FCDC7ECD87F8D97CB74BCA189@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx/
> ---
> arch/powerpc/include/asm/macio.h | 2 +-
> drivers/ata/pata_macio.c | 4 +---
> drivers/macintosh/rack-meter.c | 4 +---
> drivers/net/ethernet/apple/bmac.c | 4 +---
> drivers/net/ethernet/apple/mace.c | 4 +---
> drivers/net/wireless/intersil/orinoco/airport.c | 4 +---
> drivers/scsi/mac53c94.c | 5 +----
> drivers/scsi/mesh.c | 5 +----
> drivers/tty/serial/pmac_zilog.c | 7 ++-----
> sound/aoa/soundbus/i2sbus/core.c | 4 +---
> 10 files changed, 11 insertions(+), 32 deletions(-)

For the ata bits:

Acked-by: Damien Le Moal <damien.lemoal@xxxxxxxxxxxxxxxxxx>

--
Damien Le Moal
Western Digital Research