Re: [PATCH 2/3] arm64: dts: qcom: sm8350-hdk: correct LT9611 pin function

From: Konrad Dybcio
Date: Wed Feb 01 2023 - 10:48:09 EST




On 1.02.2023 16:43, Krzysztof Kozlowski wrote:
> SM8350 pin controller does not have "normal" pin function, so use
> "gpio".
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>
> ---
Makes one wonder if it was ever tested, as this would have probably
failed when setting pinctrl settings..

Reviewed-by: Konrad Dybcio <konrad.dybcio@xxxxxxxxxx>

Konrad
> arch/arm64/boot/dts/qcom/sm8350-hdk.dts | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/sm8350-hdk.dts b/arch/arm64/boot/dts/qcom/sm8350-hdk.dts
> index ece1a7cb8b3b..8b7cc45b0919 100644
> --- a/arch/arm64/boot/dts/qcom/sm8350-hdk.dts
> +++ b/arch/arm64/boot/dts/qcom/sm8350-hdk.dts
> @@ -725,7 +725,7 @@ usb_hub_enabled_state: usb-hub-enabled-state {
> lt9611_state: lt9611-state {
> rst-pins {
> pins = "gpio48";
> - function = "normal";
> + function = "gpio";
>
> output-high;
> input-disable;