Re: [PATCH 1/3] arm64: dts: qcom: sm8350-hdk: align pin config node names with bindings

From: Konrad Dybcio
Date: Wed Feb 01 2023 - 10:47:33 EST




On 1.02.2023 16:43, Krzysztof Kozlowski wrote:
> Bindings expect pins to be named with certain pattern.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>
>
> ---
Do we want a Fixes: here?

Reviewed-by: Konrad Dybcio <konrad.dybcio@xxxxxxxxxx>

Konrad
>
> Endless work... People keep sending patches without running dtbs_check
> faster than I am fixing existing warnings.
> ---
> arch/arm64/boot/dts/qcom/sm8350-hdk.dts | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/sm8350-hdk.dts b/arch/arm64/boot/dts/qcom/sm8350-hdk.dts
> index df841230d1b7..ece1a7cb8b3b 100644
> --- a/arch/arm64/boot/dts/qcom/sm8350-hdk.dts
> +++ b/arch/arm64/boot/dts/qcom/sm8350-hdk.dts
> @@ -723,7 +723,7 @@ usb_hub_enabled_state: usb-hub-enabled-state {
> };
>
> lt9611_state: lt9611-state {
> - rst {
> + rst-pins {
> pins = "gpio48";
> function = "normal";
>
> @@ -731,7 +731,7 @@ rst {
> input-disable;
> };
>
> - irq {
> + irq-pins {
> pins = "gpio50";
> function = "gpio";
> bias-disable;