Re: [PATCH v4 1/5] dt-bindings: regulator: Add ADI MAX77541/MAX77540 Regulator

From: Krzysztof Kozlowski
Date: Wed Feb 01 2023 - 09:46:44 EST


On 01/02/2023 11:35, Okan Sahin wrote:
> Add ADI MAX77541/MAX77540 Regulator devicetree document.
>
> Signed-off-by: Okan Sahin <okan.sahin@xxxxxxxxxx>
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>
> ---
> .../regulator/adi,max77541-regulator.yaml | 44 +++++++++++++++++++
> 1 file changed, 44 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/regulator/adi,max77541-regulator.yaml
>
> diff --git a/Documentation/devicetree/bindings/regulator/adi,max77541-regulator.yaml b/Documentation/devicetree/bindings/regulator/adi,max77541-regulator.yaml
> new file mode 100644
> index 000000000000..fff463d5e79d
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/regulator/adi,max77541-regulator.yaml
> @@ -0,0 +1,44 @@
> +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/regulator/adi,max77541-regulator.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Buck Converter for MAX77540/MAX77541
> +
> +maintainers:
> + - Okan Sahin <okan.sahin@xxxxxxxxxx>
> +
> +description: |
> + This is a part of device tree bindings for ADI MAX77540/MAX77541
> +
> + The buck converter is represented as a sub-node of the PMIC node on the device tree.
> +
> + The device has two buck regulators.
> + See also Documentation/devicetree/bindings/mfd/adi,max77541.yaml for
> + additional information and example.
> +
> +properties:
> + compatible:
> + enum:
> + - adi,max77540-regulator
> + - adi,max77541-regulator

Why do need the compatible? I don't see any usage of it in the driver
(empty driver data).

Best regards,
Krzysztof