Re: [PATCH] ALSA: emu10k1: clean up some inconsistent indenting

From: Takashi Iwai
Date: Wed Feb 01 2023 - 07:12:35 EST


On Tue, 31 Jan 2023 09:43:04 +0100,
Jiapeng Chong wrote:
>
> No functional modification involved.
>
> sound/pci/emu10k1/memory.c:446 snd_emu10k1_synth_free() warn: inconsistent indenting.

How is this warning generated? Does it come from clang or any other
compiler, or is it just some tool?

In general, I take such a white-space-fix-only patch when it's tied
with other real fix patches. But if the compiler warns, it's worth to
pick up, of course.


thanks,

Takashi

>
> Reported-by: Abaci Robot <abaci@xxxxxxxxxxxxxxxxx>
> Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=3903
> Signed-off-by: Jiapeng Chong <jiapeng.chong@xxxxxxxxxxxxxxxxx>
> ---
> sound/pci/emu10k1/memory.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/sound/pci/emu10k1/memory.c b/sound/pci/emu10k1/memory.c
> index edb3f1763719..6a7406014f81 100644
> --- a/sound/pci/emu10k1/memory.c
> +++ b/sound/pci/emu10k1/memory.c
> @@ -443,7 +443,7 @@ snd_emu10k1_synth_free(struct snd_emu10k1 *emu, struct snd_util_memblk *memblk)
> unmap_memblk(emu, blk);
> spin_unlock_irqrestore(&emu->memblk_lock, flags);
> synth_free_pages(emu, blk);
> - __snd_util_mem_free(hdr, memblk);
> + __snd_util_mem_free(hdr, memblk);
> mutex_unlock(&hdr->block_mutex);
> return 0;
> }
> --
> 2.20.1.7.g153144c
>