Re: [PATCH v5 06/39] x86/fpu: Add helper for modifying xstate

[Borislav Petkov]

On Thu, Jan 19, 2023 at 01:22:44PM -0800, Rick Edgecombe wrote:
> +void fpregs_lock_and_load(void)
> +{
> +	/*
> +	 * fpregs_lock() only disables preemption (mostly). So modifying state
> +	 * in an interrupt could screw up some in progress fpregs operation,
> +	 * but appear to work. Warn about it.

I don't like comments where it sounds like we don't know what we're
doing. "Appear to work"?

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette