Re: [PATCH 1/2] 9p/xen: fix version parsing

[Juergen Gross]

On 31.01.23 19:48, Simon Horman wrote:
> On Mon, Jan 30, 2023 at 12:30:35PM +0100, Juergen Gross wrote:
> > When connecting the Xen 9pfs frontend to the backend, the "versions"
> > Xenstore entry written by the backend is parsed in a wrong way.
> >
> > The "versions" entry is defined to contain the versions supported by
> > the backend separated by commas (e.g. "1,2"). Today only version "1"
> > is defined. Unfortunately the frontend doesn't look for "1" being
> > listed in the entry, but it is expecting the entry to have the value
> > "1".
> >
> > This will result in failure as soon as the backend will support e.g.
> > versions "1" and "2".
> >
> > Fix that by scanning the entry correctly.
> >
> > Fixes: 71ebd71921e4 ("xen/9pfs: connect to the backend")
> > Signed-off-by: Juergen Gross <jgross@xxxxxxxx>
>
> It's unclear if this series is targeted at 'net' or 'net-next'.
> FWIIW, I feel I feel it would be more appropriate for the latter
> as these do not feel like bug fixes: feel free to differ on that.

I'm fine with net-next.

Right now there is no problem with the current behavior. This will
change only in case Xen starts to support a new transport version.

For the other patch the problem would show up only if Xen starts
supporting dynamical attach/detach of 9pfs devices, which is not
the case right now.

> Regardless,
>
> Reviewed-by: Simon Horman <simon.horman@xxxxxxxxxxxx>

Thanks,


Juergen

Attachment: OpenPGP_0xB0DE9DD628BF132F.asc
Description: OpenPGP public key

Attachment: OpenPGP_signature
Description: OpenPGP digital signature