Re: [PATCH] EDAC/altera: Remove redundant error logging

From: Deepak R Varma
Date: Sat Jan 07 2023 - 15:07:49 EST


On Thu, Dec 22, 2022 at 05:37:24PM +0530, Deepak R Varma wrote:
> A call to platform_get_irq() already prints an error on failure within
> its own implementation. So printing another error based on its return
> value in the caller is redundant and should be removed. The clean up
> also makes if condition block braces unnecessary. Remove that as well.
>
> Issue identified using platform_get_irq.cocci coccinelle semantic patch.
>
> Signed-off-by: Deepak R Varma <drv@xxxxxxxxx>

Hello,
Requesting a review and feedback on this patch proposal?

Thank you,
./drv