Re: [PATCH] kbuild: rust: move rust/target.json to scripts/

[Masahiro Yamada]

On Sun, Jan 1, 2023 at 12:08 AM Miguel Ojeda
<miguel.ojeda.sandonis@xxxxxxxxx> wrote:
>
> On Sat, Dec 31, 2022 at 3:57 PM Masahiro Yamada <masahiroy@xxxxxxxxxx> wrote:
> >
> > No.
> > scripts/target.json is a generated file.
> > It is generated in objtree, not in srctree.
>
> I meant `$(objtree)`, i.e. I meant if we should use a $(...)` prefix
> for clarity/consistency (even if it is just `.`).


I usually do not add $(objtree)/.


include/config/auto.conf is also a generated file.

It is inconsistent to add $(objtree)/
to scripts/generate_rust_target,
but not to include/config/auto.conf.



(obj)/target.json: $(objtree)/scripts/generate_rust_target
$(objtree)/include/config/auto.conf FORCE
          $(call filechk,rust_target)

is annoying.



-- 
Best Regards
Masahiro Yamada