Re: [PATCH v2 1/2] spi: spidev: fix a race condition when accessing spidev->spi

From: Mark Brown
Date: Fri Jan 06 2023 - 11:17:18 EST


On Fri, Jan 06, 2023 at 03:27:57PM +0100, Bartosz Golaszewski wrote:

> IMO the complication of using an RW semaphore is insignificant and
> maybe a comment next to its declaration in struct spidev would
> suffice?

The complication is using a semaphore at all, it's a pretty unusual
locking construct and the whole up/down thing isn't clear to people
who aren't familiar with it. Given that there's no clounting being
used rwlock would be a much more obvious choice if the microseconds
of extra concurrency is meaningful somehow.

Attachment: signature.asc
Description: PGP signature