RE: [PATCH v2 2/6] x86/tdx: Support vmalloc() for tdx_enc_status_changed()

From: Dexuan Cui
Date: Fri Jan 06 2023 - 10:40:18 EST


> From: Zhi Wang <zhi.wang.linux@xxxxxxxxx>
> Sent: Friday, January 6, 2023 2:11 AM
> To: Dexuan Cui <decui@xxxxxxxxxxxxx>
> [...]
> I guess we both agree that memory conversion in HV should be done through
> coco so the hv_map_memory can be removed (even the extra does not hurt
> currently)

Correct. As I mentioned, Michael's pachset is doing that and hopefully it would
be merged into the upstream soon.

> The memory conversion in current HV code is done by different approaches.
> Some are going through the coco, some are not, which ends up
> with if(hv_isolation_type_snp()) in memory allocation path. It can be
> confusing. I suppose a reasonable purpose of hv_isolation_type_snp()
> should cover the AMD SEV-SNP specific parts which haven't been (or are
> not going to be) covered by coco. For example the GHCB stuff.
>
> Thanks,
> Zhi.

Exactly.