Re: [PATCH net-next v1 1/3] dt-bindings: net: Add Motorcomm yt8xxx ethernet phy Driver bindings

From: Andrew Lunn
Date: Fri Jan 06 2023 - 08:58:36 EST


> >> + motorcomm,rx-delay-basic:
> >> + description: |
> >> + Tristate, setup the basic RGMII RX Clock delay of PHY.
> >> + This basic delay is fixed at 2ns (1000Mbps) or 8ns (100Mbps、10Mbps).
> >> + This basic delay usually auto set by hardware according to the voltage
> >> + of RXD0 pin (low = 0, turn off; high = 1, turn on).
> >> + If not exist, this delay is controlled by hardware.
> >
> > I don't understand that at all. What "not exist"? There is no verb and
> > no subject.
> >
> > The type and description are really unclear.
> >
> >> + 0: turn off; 1: turn on.
> >> + $ref: /schemas/types.yaml#/definitions/uint32
> >> + enum: [0, 1]
> >
> > So this is bool?
> >
>
> This basic delay can be controlled by hardware or dts.
>
> Default value depends on power on strapping, according to the voltage
> of RXD0 pin (low = 0, turn off; high = 1, turn on).
>
> "not exist" means that This basic delay is controlled by hardware,
> and software don't change this.

As i said in my other reply, this is not how Linux controls this. This
property should be removed.

Andrew