Re: [PATCH V4 1/3] dt-bindings: arm: ti: Add binding for AM68 SK

From: Nishanth Menon
Date: Fri Jan 06 2023 - 08:37:32 EST


On 13:58-20230106, Krzysztof Kozlowski wrote:
> On 06/01/2023 13:53, Sinthu Raja M wrote:
> > On Fri, Jan 6, 2023 at 6:19 PM Krzysztof Kozlowski
> > <krzysztof.kozlowski@xxxxxxxxxx> wrote:
> >>
> >> On 05/01/2023 16:17, Sinthu Raja wrote:
> >>> From: Sinthu Raja <sinthu.raja@xxxxxx>
> >>>
> >>> AM68 Starter Kit is a low cost, small form factor board designed for
> >>> TI's AM68 SoC which is optimized to provide best in class performance
> >>> for industrial applications and add binding for the same.
> >>>
> >>> Signed-off-by: Sinthu Raja <sinthu.raja@xxxxxx>
> >>
> >> What happened here?,
> > Krzysztof
> > Missed the merge window, so rebased to 6.2rc1 and reposted again.
>
> And what was here in v3?

Sinthu, If I am not mistaken (Krzysztof can correct me), what is meant here
are two things:

a) if no modification to the patch was made and just a repost is being done,
just indicate that in $subject. Examples: [1]

b) Ensure that there is a changelog. I understand that the
cover letter[2] has indicated this, but keep in mind that reviewers use
filters, and cover-letter does'nt fall into their filter. I usually
capture the change information per patch as well. If you are a b4 fan,
see Konstantin's tips with B4 in [3][4]

[1] https://lore.kernel.org/linux-arm-kernel/?q=RESEND
[2] https://lore.kernel.org/all/20230105151740.29436-1-sinthu.raja@xxxxxx/
[3] https://people.kernel.org/monsieuricon/sending-a-kernel-patch-with-b4-part-1
[4] https://www.youtube.com/watch?v=-Vld9aoFPwU
--
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D