Re: [PATCH 1/3] dt-bindings: clock: document SM8550 DISPCC clock controller

[Krzysztof Kozlowski]

On 03/01/2023 14:53, Neil Armstrong wrote:
> Document device tree bindings for display clock controller for
> Qualcomm SM8550 SoC.
> 
> Signed-off-by: Neil Armstrong <neil.armstrong@xxxxxxxxxx>
> ---
>  .../bindings/clock/qcom,sm8550-dispcc.yaml         | 106 +++++++++++++++++++++
>  include/dt-bindings/clock/qcom,sm8550-dispcc.h     | 101 ++++++++++++++++++++
>  2 files changed, 207 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/clock/qcom,sm8550-dispcc.yaml b/Documentation/devicetree/bindings/clock/qcom,sm8550-dispcc.yaml
> new file mode 100644
> index 000000000000..06c04656cb55
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/clock/qcom,sm8550-dispcc.yaml
> @@ -0,0 +1,106 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/clock/qcom,sm8550-dispcc.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Qualcomm Display Clock & Reset Controller for SM8550
> +
> +maintainers:
> +  - Bjorn Andersson <andersson@xxxxxxxxxx>
> +  - Neil Armstrong <neil.armstrong@xxxxxxxxxx>
> +
> +description: |
> +  Qualcomm display clock control module provides the clocks, resets and power
> +  domains on SM8550.
> +
> +  See also:: include/dt-bindings/clock/qcom,sm8550-dispcc.h
> +
> +properties:
> +  compatible:
> +    enum:
> +      - qcom,sm8550-dispcc
> +
> +  clocks:
> +    minItems: 3

Clock inputs should be optional if we can really treat them optional,
e.g. reparent to something else or just adjust list of parents. Since
the driver has fixed parent data, it suggests these are not really
optional and they are all in the hardware (always).


Best regards,
Krzysztof