Re: [PATCH v6 net-next 1/2] net: phy: micrel: Fixed error related to uninitialized symbol ret

From: Arun.Ramadoss
Date: Fri Jan 06 2023 - 04:17:25 EST


Hi Divya,

On Fri, 2023-01-06 at 13:59 +0530, Divya Koppera wrote:
> Initialized return variable
>
> Fixes Old smatch warnings:
> drivers/net/phy/micrel.c:1750 ksz886x_cable_test_get_status() error:
> uninitialized symbol 'ret'.
>
> Reported-by: kernel test robot <lkp@xxxxxxxxx>
> Reported-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
> Reviewed-by: Andrew Lunn <andrew@xxxxxxx>
> Signed-off-by: Divya Koppera <Divya.Koppera@xxxxxxxxxxxxx>

I think, Reviewed-by tag should come after signed-off tag. It should be
in chronological order.