Re: [PATCH v2 1/2] dt-bindings: soc: qcom: eud: Add SM6115 / SM4250 binding

From: Krzysztof Kozlowski
Date: Fri Jan 06 2023 - 04:13:57 EST


On 03/01/2023 16:04, Bhupesh Sharma wrote:
> Add dt-bindings for EUD found on Qualcomm SM6115 / SM4250 SoC.
>
> On this SoC (and derivatives) the enable bit inside 'tcsr_check_reg'
> needs to be set first to 'enable' the eud module.
>

Subject: drop second, redundant "binding".


> So, update the dt-bindings to accommodate the third register
> property required by the driver on these SoCs.
>
> Cc: Souradeep Chowdhury <quic_schowdhu@xxxxxxxxxxx>
> Signed-off-by: Bhupesh Sharma <bhupesh.sharma@xxxxxxxxxx>
> ---
> .../devicetree/bindings/soc/qcom/qcom,eud.yaml | 10 ++++++++++
> 1 file changed, 10 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/soc/qcom/qcom,eud.yaml b/Documentation/devicetree/bindings/soc/qcom/qcom,eud.yaml
> index c98aab209bc5d..1dffe14868735 100644
> --- a/Documentation/devicetree/bindings/soc/qcom/qcom,eud.yaml
> +++ b/Documentation/devicetree/bindings/soc/qcom/qcom,eud.yaml
> @@ -18,12 +18,22 @@ properties:
> items:
> - enum:
> - qcom,sc7280-eud
> + - qcom,sm6115-eud
> - const: qcom,eud
>
> reg:
> + minItems: 2
> items:
> - description: EUD Base Register Region
> - description: EUD Mode Manager Register
> + - description: TCSR Check Register

Is this valid also for sc7280? From commit description looks like not,
so you should have allOf:if:then constraining the items per variant.

> +
> + reg-names:
> + minItems: 2
> + items:
> + - const: eud-base
> + - const: eud-mode-mgr
> + - const: tcsr-check-base
>
> interrupts:
> description: EUD interrupt

Best regards,
Krzysztof