Re: [PATCH printk v4 4/8] printk: introduce struct printk_buffers

From: Petr Mladek
Date: Thu Jan 05 2023 - 10:07:10 EST


On Thu 2023-01-05 11:43:31, John Ogness wrote:
> Introduce a new struct printk_buffers to contain all the buffers
> needed to read and format a printk message for output. Putting the
> buffers inside a struct reduces the number of buffer pointers that
> need to be tracked. Also, it allows usage of the sizeof() macro for
> the buffer sizes, rather than expecting certain sized buffers being
> passed in.
>
> Note that since the output buffer for normal consoles is now
> CONSOLE_EXT_LOG_MAX instead of CONSOLE_LOG_MAX, multi-line
> messages that may have been previously truncated will now be
> printed in full. This should be considered a feature and not a bug
> since the CONSOLE_LOG_MAX restriction was about limiting static
> buffer usage rather than limiting printed text.
>
> Signed-off-by: John Ogness <john.ogness@xxxxxxxxxxxxx>

Reviewed-by: Petr Mladek <pmladek@xxxxxxxx>

Best Regards,
Petr