Re: [PATCH 1/2] dt-bindings: display: panel: document the Visionox VTDR6130 AMOLED DSI Panel bindings

[Neil Armstrong]

On 03/01/2023 18:57, Sam Ravnborg wrote:
> Hi Neil,
>
> On Tue, Jan 03, 2023 at 03:22:27PM +0100, Neil Armstrong wrote:
> > Document the 1080x2400 Visionox VTDR6130 AMOLED DSI Panel bindings.
> >
> > Signed-off-by: Neil Armstrong <neil.armstrong@xxxxxxxxxx>
> > ---
> >   .../bindings/display/panel/visionox,vtdr6130.yaml  | 53 ++++++++++++++++++++++
> >   1 file changed, 53 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/display/panel/visionox,vtdr6130.yaml b/Documentation/devicetree/bindings/display/panel/visionox,vtdr6130.yaml
> > new file mode 100644
> > index 000000000000..49e2fd4b4e99
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/display/panel/visionox,vtdr6130.yaml
> > @@ -0,0 +1,53 @@
> > +# SPDX-License-Identifier: GPL-2.0-only or BSD-2-Clause
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/display/panel/visionox,vtdr6130.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: Visionox VTDR6130 AMOLED DSI Panel
> > +
> > +maintainers:
> > +  - Neil Armstrong <neil.armstrong@xxxxxxxxxx>
> > +
> > +allOf:
> > +  - $ref: panel-common.yaml#
> > +
> > +properties:
> > +  compatible:
> > +    const: visionox,vtdr6130
> > +
> > +  vddio-supply: true
> > +  vci-supply: true
> > +  vdd-supply: true
> These 3 looks wrong to me, as the above are not documented in panel-common.
> But maybe I miss something and this is OK?

It should be OK, the XXXX-supply properties are standard properties

Neil

> 	Sam
>
> > +  port: true
> > +  reset-gpios: true
> > +
> > +additionalProperties: false
> > +
> > +required:
> > +  - compatible
> > +  - vddio-supply
> > +  - vci-supply
> > +  - vdd-supply
> > +  - reset-gpios
> > +  - port
> > +
> > +examples:
> > +  - |
> > +    #include <dt-bindings/gpio/gpio.h>
> > +    panel {
> > +        compatible = "visionox,vtdr6130";
> > +
> > +        vddio-supply = <&vreg_l12b_1p8>;
> > +        vci-supply = <&vreg_l13b_3p0>;
> > +        vdd-supply = <&vreg_l11b_1p2>;
> > +
> > +        reset-gpios = <&tlmm 133 GPIO_ACTIVE_LOW>;
> > +
> > +        port {
> > +            panel0_in: endpoint {
> > +                remote-endpoint = <&dsi0_out>;
> > +            };
> > +        };
> > +    };
> > +...
> >
> > --
> > 2.34.1