Re: [RFC PATCH v3 2/2] mfd: syscon: allow reset control for syscon devices

[Lee Jones]

On Thu, 05 Jan 2023, Jeremy Kerr wrote:

> Hi Lee,
> 
> > > @@ -124,7 +127,17 @@ static struct syscon *of_syscon_register(struct device_node *np, bool check_clk)
> > >                 } else {
> > >                         ret = regmap_mmio_attach_clk(regmap, clk);
> > >                         if (ret)
> > > -                               goto err_attach;
> > > +                               goto err_attach_clk;
> > > +               }
> > > +
> > > +               reset = of_reset_control_get_optional_exclusive(np, NULL);
> > > +               if (IS_ERR(reset)) {
> > > +                       ret = PTR_ERR(reset);
> > > +                       goto err_attach_clk;
> > > +               } else {
> > > +                       ret = reset_control_deassert(reset);
> > > +                       if (ret)
> > > +                               goto err_reset;
> > >                 }
> > 
> > The else is superfluous, right?
> 
> Yep, we could move that reset_control_deassert() out of the else block.
> If there are no other changes, I'll send a v4 with that.

I'd wait a little while to give Arnd a chance to respond.

Might save you a little work.

-- 
Lee Jones [李琼斯]