Re: [PATCH 3/3] wiegand: add Wiegand GPIO bit-banged controller driver

From: Andy Shevchenko
Date: Wed Jan 04 2023 - 12:04:33 EST


On Wed, Jan 04, 2023 at 06:59:00PM +0200, Andy Shevchenko wrote:
> On Wed, Jan 04, 2023 at 02:34:14PM +0100, Martin Zaťovič wrote:

...

> > +What: /sys/devices/platform/.../wiegand-gpio-attributes/format

> > +What: /sys/devices/platform/.../wiegand-gpio-attributes/payload_len

> Why all these attributes? What is special about them and how they are specific
> to the hardware in question?
>
> To me it all sounds like layering violation: a GPIO driver that has to be
> generic provides a complete custom ABIs which we usually put on the upper
> layer (in the kernel as a child driver or in the user space).

Okay, it seems the consumer driver.

--
With Best Regards,
Andy Shevchenko