Re: [PATCH v4 2/5] dt-bindings: hwmon: Add hpe,gxp-fan-ctrl

From: Guenter Roeck
Date: Tue Jan 03 2023 - 16:35:22 EST


On Tue, Jan 03, 2023 at 02:36:51PM -0600, nick.hawkins@xxxxxxx wrote:
> From: Nick Hawkins <nick.hawkins@xxxxxxx>
>
> Create documentation for the binding to support control of the fans on
> HPE platforms.
>
> Signed-off-by: Nick Hawkins <nick.hawkins@xxxxxxx>
> Reviewed-by: Rob Herring <robh@xxxxxxxxxx>
> Reviewed-by: Guenter Roeck <linux@xxxxxxxxxxxx>

Applied to hwmon-next.

Thanks,
Guenter

> ---
> v4:
> *No change
> v3:
> *No change
> v2:
> *Changed plreg to pl
> *Changed fn2reg to reg
> *Edited descriptions for all registers
> *Changed fanctrl to fan-controller
> *Changed commit description
> ---
> .../bindings/hwmon/hpe,gxp-fan-ctrl.yaml | 45 +++++++++++++++++++
> 1 file changed, 45 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/hwmon/hpe,gxp-fan-ctrl.yaml
>
> diff --git a/Documentation/devicetree/bindings/hwmon/hpe,gxp-fan-ctrl.yaml b/Documentation/devicetree/bindings/hwmon/hpe,gxp-fan-ctrl.yaml
> new file mode 100644
> index 000000000000..4a52aac6be72
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/hwmon/hpe,gxp-fan-ctrl.yaml
> @@ -0,0 +1,45 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/hwmon/hpe,gxp-fan-ctrl.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: HPE GXP Fan Controller
> +
> +maintainers:
> + - Nick Hawkins <nick.hawkins@xxxxxxx>
> +
> +description: |
> + The HPE GXP fan controller controls the fans through an external CPLD
> + device that connects to the fans.
> +
> +properties:
> + compatible:
> + const: hpe,gxp-fan-ctrl
> +
> + reg:
> + items:
> + - description: Fan controller PWM
> + - description: Programmable logic
> + - description: Function 2
> +
> + reg-names:
> + items:
> + - const: base
> + - const: pl
> + - const: fn2
> +
> +required:
> + - compatible
> + - reg
> + - reg-names
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + fan-controller@1000c00 {
> + compatible = "hpe,gxp-fan-ctrl";
> + reg = <0x1000c00 0x200>, <0xd1000000 0xff>, <0x80200000 0x100000>;
> + reg-names = "base", "pl", "fn2";
> + };