Re: [PATCH] KVM: Destroy target device if coalesced MMIO unregistration fails

From: Sean Christopherson
Date: Tue Jan 03 2023 - 11:33:49 EST


On Mon, Dec 26, 2022, Wang, Wei W wrote:
> On Saturday, December 24, 2022 1:14 AM, Paolo Bonzini wrote:
> > On 12/20/22 04:04, Wang, Wei W wrote:
> > > Another option is to let kvm_io_bus_unregister_dev handle this, and no
> > > need for callers to make the extra kvm_iodevice_destructor() call.
> > > This simplifies the usage for callers (e.g. reducing LOCs and no leakages like
> > this):
> >
> > Can you send this as a patch? Thanks!
>
> Sure. I can do it. I'm also fine if Sean would be interested in taking over the
> code

No thanks.

> (or anything I should do to keep his credits for the original fixing?)

No need. If anything, take my patch first so that the fix for stable kernels is
trivial. That's Paolo's call though.