Re: [PATCH] arm64: dts: qcom: msm8998-yoshino: Use SONY GPIO names

[Dmitry Baryshkov]

On 02/01/2023 21:01, Konrad Dybcio wrote:
> Sony ever so graciously provides GPIO line names in their downstream
> kernel (though sometimes they are not 100% accurate and you can judge
> that by simply looking at them and with what drivers they are used).
>
> Add these to the Yoshino devices DTs to better document the hardware and
> rename already-defined GPIO nodes to fit the "official" names.
> Note that 4k_ is replaced with four_k_ in one pin, as labels can't start
> with numbers.
>
> Lilac and Poplar have identical pin assignments.
>
> Diff between these two and maple:
>
> TLMM:
> -  "NC",
> +  "TS_VDDIO_EN",
>
> PMI8998:
> -  "NC"
> +  "USB_SWITCH_SEL"
>
> -  "NC"
> +  "4K_DISP_DCDC_EN"
>
> PM8005:
> -  "NC"
> +  "EAR_EN"
>
> Which is probably due to Maple being designed and released quite a bit
> earlier than the other two and it having a super high tech true-4K
> display.
>
> Signed-off-by: Konrad Dybcio <konrad.dybcio@xxxxxxxxxx>
> ---
>   .../msm8998-sony-xperia-yoshino-maple.dts     | 179 +++++++++++-
>   .../dts/qcom/msm8998-sony-xperia-yoshino.dtsi | 260 +++++++++++++++---


The patch doesn't only add GPIO names, but also changes some labels and 
node names. I can not judge whether they are correct changes or not, but 
they definitely should be split out of the GPIO names patch.


>   2 files changed, 406 insertions(+), 33 deletions(-)
--
With best wishes
Dmitry