Re: [PATCH 1/2] brcmfmac: Use separate struct to declare firmware names for Apple OTP chips

From: Hector Martin
Date: Mon Jan 02 2023 - 10:15:57 EST


On 02/01/2023 23.40, Aditya Garg wrote:
> From: Aditya Garg <gargaditya08@xxxxxxxx>
>
> Commit 'dce45ded7619' added support for 89459 chip pcie device. It uses the
> BRCM4355 chip which is also found in Apple hardware. However this commit
> causes conflicts in the firmware naming between Apple hardware, which
> supports OTP and other non-Apple hardwares. So, this patch makes these
> Apple chips use their own firmware table so as to avoid possible conflicts
> like these in the future.
>

I think my reply to Arend flew over your head.

My point was that I'd rather have the Broadcom/Cypress people actually
answer my question so we can figure out how to do this *properly*,
instead of doing "safer-but-dumb" things (like this patch) because we
just don't have the information to do it properly.

- Hector