Re: [PATCH 5/7] mtd: rawnand: sunxi: Fix the size of the last OOB region

From: Gole, Dhruva
Date: Mon Jan 02 2023 - 04:01:16 EST



On 12/29/2022 11:45 PM, Samuel Holland wrote:
The previous code assigned to the wrong structure member.
Good catch!

Fixes: c66811e6d350 ("mtd: nand: sunxi: switch to mtd_ooblayout_ops")
Signed-off-by: Samuel Holland <samuel@xxxxxxxxxxxx>
---
Acked-By: Dhruva Gole <d-gole@xxxxxx>

drivers/mtd/nand/raw/sunxi_nand.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/mtd/nand/raw/sunxi_nand.c b/drivers/mtd/nand/raw/sunxi_nand.c
index 1ecf2cee343b..8e873f4fec9a 100644
--- a/drivers/mtd/nand/raw/sunxi_nand.c
+++ b/drivers/mtd/nand/raw/sunxi_nand.c
@@ -1609,7 +1609,7 @@ static int sunxi_nand_ooblayout_free(struct mtd_info *mtd, int section,
if (section < ecc->steps)
oobregion->length = 4;
else
- oobregion->offset = mtd->oobsize - oobregion->offset;
+ oobregion->length = mtd->oobsize - oobregion->offset;
return 0;
}

--
Regards,
Dhruva Gole <d-gole@xxxxxx>