Re: [PATCH] clk: qcom: dispcc-sm6125: Fix compatible string to match bindings

From: AngeloGioacchino Del Regno
Date: Fri Dec 23 2022 - 04:27:06 EST


Il 22/12/22 22:01, Marijn Suijten ha scritto:
According to generic rules the SoC name should be first:

arch/arm64/boot/dts/qcom/sm6125-sony-xperia-seine-pdx201.dtb: clock-controller@5f00000: compatible: 'oneOf' conditional failed, one must be fixed:
'qcom,dispcc-sm6125' does not match '^qcom,(apq|ipq|mdm|msm|qcm|qcs|sa|sc|sdm|sdx|sm)[0-9]+-.*$'

And this is already reflected by the bindings submitted prior to the
addition of this driver. Any DTS following these rules will end up with
a non-probing driver because of this mismatch.

Fixes: 6e87c8f07407 ("clk: qcom: Add display clock controller driver for SM6125")
Signed-off-by: Marijn Suijten <marijn.suijten@xxxxxxxxxxxxxx>

Since there's no devicetree that is currently using the wrong compatible, you
are *not* breaking anything - hence fixing that issue without any regression.

Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@xxxxxxxxxxxxx>