Re: [PATCH v3 2/3] mm: vmalloc: Switch to find_unlink_vmap_area() in vm_unmap_ram()

From: Christoph Hellwig
Date: Fri Dec 23 2022 - 03:21:32 EST


On Thu, Dec 22, 2022 at 08:00:21PM +0100, Uladzislau Rezki (Sony) wrote:
> --- a/mm/vmalloc.c
> +++ b/mm/vmalloc.c
> @@ -2252,7 +2252,7 @@ void vm_unmap_ram(const void *mem, unsigned int count)
> return;
> }
>
> - va = find_vmap_area(addr);
> + va = find_unlink_vmap_area(addr);
> BUG_ON(!va);
> debug_check_no_locks_freed((void *)va->va_start,
> (va->va_end - va->va_start));

Don't we also need to remove the manual unlink that was done
here previously? Actually it seems like that manual unlink is missing
after patch 1, creating a bisection hazard. So either add it there,
or just fold this patch into the previous one.