Re: [RFC PATCH] clocksource/drivers/riscv: Get rid of clocksource_arch_init() callback

From: Lad, Prabhakar
Date: Thu Dec 22 2022 - 23:11:09 EST


On Sun, Dec 11, 2022 at 9:59 PM Prabhakar <prabhakar.csengg@xxxxxxxxx> wrote:
>
> From: Lad Prabhakar <prabhakar.mahadev-lad.rj@xxxxxxxxxxxxxx>
>
> Having a clocksource_arch_init() callback always sets vdso_clock_mode to
> VDSO_CLOCKMODE_ARCHTIMER if GENERIC_GETTIMEOFDAY is enabled, this is
> required for the riscv-timer.
>
> This works for platforms where just riscv-timer clocksource is present.
> On platforms where other clock sources are available we want them to
> register with vdso_clock_mode set to VDSO_CLOCKMODE_NONE.
>
> On the Renesas RZ/Five SoC OSTM block can be used as clocksource [0], to
> avoid multiple clock sources being registered as VDSO_CLOCKMODE_ARCHTIMER
> move setting of vdso_clock_mode in the riscv-timer driver instead of doing
> this in clocksource_arch_init() callback as done similarly for ARM/64
> architecture.
>
> [0] drivers/clocksource/renesas-ostm.c
>
> Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@xxxxxxxxxxxxxx>
> ---
> arch/riscv/Kconfig | 1 -
> arch/riscv/kernel/time.c | 9 ---------
> drivers/clocksource/timer-riscv.c | 7 +++++++
> 3 files changed, 7 insertions(+), 10 deletions(-)
>
Gentle ping for review.

Cheers,
Prabhakar