[PATCH 0/2] HID: i2c-hid: use standard debugging APIs
From: Thomas Weißschuh
Date: Thu Dec 22 2022 - 21:54:06 EST
When trying to debug i2c-hid I was not able to use the builtin debug
mechanism because the "debug" module parameter is not writable.
We can change i2c-hid to use the standard kernel debugging APIs which are
more discoverable and have more features.
There is a bit of a stilistic conflict between consistently using
i2c_hid_dbg() and consistently using dev_<level>().
The second patch aligns debugging on i2c_hid_dbg().
If this is unneeded, feel free to drop it.
It would also be easy to just use dev_dbg() everywhere for consistency.
To: Jiri Kosina <jikos@xxxxxxxxxx>
To: Benjamin Tissoires <benjamin.tissoires@xxxxxxxxxx>
Cc: linux-input@xxxxxxxxxxxxxxx
Cc: linux-kernel@xxxxxxxxxxxxxxx
Signed-off-by: Thomas Weißschuh <linux@xxxxxxxxxxxxxx>
---
Thomas Weißschuh (2):
HID: i2c-hid: switch to standard debugging APIs
HID: i2c-hid: use uniform debugging APIs
drivers/hid/i2c-hid/i2c-hid-core.c | 15 +++------------
1 file changed, 3 insertions(+), 12 deletions(-)
---
base-commit: 8395ae05cb5a2e31d36106e8c85efa11cda849be
change-id: 20221223-hid-dbg-cdc1d56d8cee
Best regards,
--
Thomas Weißschuh <linux@xxxxxxxxxxxxxx>