[PATCH] clk: renesas: cpg-mssr: Fix use after free if cpg_mssr_common_init() failed

From: Alexey Khoroshilov
Date: Thu Dec 22 2022 - 17:23:40 EST


If cpg_mssr_common_init() fails after assigning priv to global variable
cpg_mssr_priv, it deallocates priv, but cpg_mssr_priv keeps dangling
pointer that potentially can be used later.

Found by Linux Verification Center (linuxtesting.org) with SVACE.

Fixes: 1f7db7bbf031 ("clk: renesas: cpg-mssr: Add early clock support")
Signed-off-by: Alexey Khoroshilov <khoroshilov@xxxxxxxxx>
---
drivers/clk/renesas/renesas-cpg-mssr.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/clk/renesas/renesas-cpg-mssr.c b/drivers/clk/renesas/renesas-cpg-mssr.c
index 1a0cdf001b2f..27da127ca4a8 100644
--- a/drivers/clk/renesas/renesas-cpg-mssr.c
+++ b/drivers/clk/renesas/renesas-cpg-mssr.c
@@ -1025,6 +1025,7 @@ static int __init cpg_mssr_common_init(struct device *dev,
if (priv->base)
iounmap(priv->base);
kfree(priv);
+ cpg_mssr_priv = NULL;

return error;
}
--
2.7.4