Re: [PATCH 1/2] mm: add vma_has_locality()

From: Andrew Morton
Date: Thu Dec 22 2022 - 13:49:56 EST


On Wed, 21 Dec 2022 22:13:40 -0800 Yuanchu Xie <yuanchu@xxxxxxxxxx> wrote:

> From: Yu Zhao <yuzhao@xxxxxxxxxx>
>
> Currently in vm_flags in vm_area_struct, both VM_SEQ_READ and
> VM_RAND_READ indicate a lack of locality in accesses to the vma. Some
> places that check for locality are missing one of them. We add
> vma_has_locality to replace the existing locality checks for clarity.

I'm all confused. Surely VM_SEQ_READ implies locality and VM_RAND_READ
indicates no-locality?