Re: [PATCH v3 1/2] arm64: dts: rockchip: Add RK3566 LubanCat 1

From: Rob Herring
Date: Thu Dec 22 2022 - 12:25:14 EST


On Wed, Dec 21, 2022 at 01:43:07PM +0800, Yuteng Zhong wrote:
> LubanCat 1 is a Rockchip RK3566 SBC based
> is developed by EmbedFire Electronics Co., Ltd.
> Mini Linux Card Type Cheap Computer Development Board
> It has the following characteristics:
> - MicroSD card slot, onboard eMMC flash memory
> - 1GbE Realtek RTL8211F Ethernet Transceiver
> - 1 USB Type-C port (power and USB2.0 OTG)
> - 1 USB 3.0 Host port
> - 3 USB 2.0 Host ports
> - 1 HDMI
> - 1 infrared receiver
> - 1 MIPI DSI
> - 1 MIPI CSI
> - 1 x 4-section headphone jack
> - Mini PCIe socket (USB or PCIe)
> - 1 SIM Card slot
> - 1 SYS LED and 1 PWR LED
> - 40-pin GPIO expansion header
>
> Signed-off-by: Yuteng Zhong <zonyitoo@xxxxxxxxx>
> Signed-off-by: DHDAXCW <lasstp5011@xxxxxxxxx>

DHDAXCW is a legal name?

The person sending the patch email should be last.

> ---
>
> Changed in V2:
> - Remove RNG node
> Changed in V3:
> - Modify all node names
>
> ---
> .../devicetree/bindings/arm/rockchip.yaml | 5 +

Bindings should be separate patch.

> arch/arm64/boot/dts/rockchip/Makefile | 1 +
> .../boot/dts/rockchip/rk3566-lubancat-1.dts | 600 ++++++++++++++++++

Fix all the whitespace errors checkpatch.pl complains about.