RE: [PATCH net v2] powerpc: dts: t208x: Disable 10G on MAC1 and MAC2

From: Camelia Alexandra Groza
Date: Thu Dec 22 2022 - 10:41:11 EST


> -----Original Message-----
> From: Camelia Alexandra Groza <camelia.groza@xxxxxxx>
> Sent: Monday, December 19, 2022 18:23
> To: Sean Anderson <sean.anderson@xxxxxxxx>; David S . Miller
> <davem@xxxxxxxxxxxxx>; netdev@xxxxxxxxxxxxxxx
> Cc: devicetree@xxxxxxxxxxxxxxx; Rob Herring <robh+dt@xxxxxxxxxx>;
> Christophe Leroy <christophe.leroy@xxxxxxxxxx>; Nicholas Piggin
> <npiggin@xxxxxxxxx>; Michael Ellerman <mpe@xxxxxxxxxxxxxx>; linuxppc-
> dev@xxxxxxxxxxxxxxxx; Krzysztof Kozlowski
> <krzysztof.kozlowski+dt@xxxxxxxxxx>; linux-kernel@xxxxxxxxxxxxxxx; Sean
> Anderson <sean.anderson@xxxxxxxx>
> Subject: RE: [PATCH net v2] powerpc: dts: t208x: Disable 10G on MAC1 and
> MAC2
>
> > -----Original Message-----
> > From: Sean Anderson <sean.anderson@xxxxxxxx>
> > Sent: Friday, December 16, 2022 19:30
> > To: David S . Miller <davem@xxxxxxxxxxxxx>; netdev@xxxxxxxxxxxxxxx
> > Cc: devicetree@xxxxxxxxxxxxxxx; Rob Herring <robh+dt@xxxxxxxxxx>;
> > Christophe Leroy <christophe.leroy@xxxxxxxxxx>; Nicholas Piggin
> > <npiggin@xxxxxxxxx>; Michael Ellerman <mpe@xxxxxxxxxxxxxx>; linuxppc-
> > dev@xxxxxxxxxxxxxxxx; Krzysztof Kozlowski
> > <krzysztof.kozlowski+dt@xxxxxxxxxx>; linux-kernel@xxxxxxxxxxxxxxx;
> Camelia
> > Alexandra Groza <camelia.groza@xxxxxxx>; Sean Anderson
> > <sean.anderson@xxxxxxxx>
> > Subject: [PATCH net v2] powerpc: dts: t208x: Disable 10G on MAC1 and
> > MAC2
> >
> > There aren't enough resources to run these ports at 10G speeds. Disable
> > 10G for these ports, reverting to the previous speed.
> >
> > Fixes: 36926a7d70c2 ("powerpc: dts: t208x: Mark MAC1 and MAC2 as 10G")
> > Reported-by: Camelia Alexandra Groza <camelia.groza@xxxxxxx>
> > Signed-off-by: Sean Anderson <sean.anderson@xxxxxxxx>
> > ---
>
> Thank you.
>
> Reviewed-by: Camelia Groza <camelia.groza@xxxxxxx>
> Tested-by: Camelia Groza <camelia.groza@xxxxxxx>

I see the patch marked Not Applicable in the netdev patchwork.
What tree will it go through?

> > Changes in v2:
> > - Remove the 10g properties, instead of removing the MAC dtsis.
> >
> > arch/powerpc/boot/dts/fsl/t2081si-post.dtsi | 16 ++++++++++++++++
> > 1 file changed, 16 insertions(+)
> >
> > diff --git a/arch/powerpc/boot/dts/fsl/t2081si-post.dtsi
> > b/arch/powerpc/boot/dts/fsl/t2081si-post.dtsi
> > index 74e17e134387..27714dc2f04a 100644
> > --- a/arch/powerpc/boot/dts/fsl/t2081si-post.dtsi
> > +++ b/arch/powerpc/boot/dts/fsl/t2081si-post.dtsi
> > @@ -659,3 +659,19 @@ L2_1: l2-cache-controller@c20000 {
> > interrupts = <16 2 1 9>;
> > };
> > };
> > +
> > +&fman0_rx_0x08 {
> > + /delete-property/ fsl,fman-10g-port;
> > +};
> > +
> > +&fman0_tx_0x28 {
> > + /delete-property/ fsl,fman-10g-port;
> > +};
> > +
> > +&fman0_rx_0x09 {
> > + /delete-property/ fsl,fman-10g-port;
> > +};
> > +
> > +&fman0_tx_0x29 {
> > + /delete-property/ fsl,fman-10g-port;
> > +};
> > --
> > 2.35.1.1320.gc452695387.dirty