Re: [PATCH v4 1/4] arm64: dts: qcom: sdm845-db845c: fix audio codec interrupt pin name

From: Konrad Dybcio
Date: Thu Dec 22 2022 - 10:14:34 EST




On 22.12.2022 16:13, Krzysztof Kozlowski wrote:
> The pin config entry should have a string, not number, for the GPIO used
> as WCD9340 audio codec interrupt.
>
> Fixes: 89a32a4e769c ("arm64: dts: qcom: db845c: add analog audio support")
> Reported-by: Doug Anderson <dianders@xxxxxxxxxxxx>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>
> Reviewed-by: Douglas Anderson <dianders@xxxxxxxxxxxx>
>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@xxxxxxxxxx>

Konrad
>
> Cc: Doug Anderson <dianders@xxxxxxxxxxxx>
>
> Changes since v3:
> 1. Add Fixes and Rb tags.
>
> Changes since v2:
> 1. New patch.
> ---
> arch/arm64/boot/dts/qcom/sdm845-db845c.dts | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/sdm845-db845c.dts b/arch/arm64/boot/dts/qcom/sdm845-db845c.dts
> index f41c6d600ea8..774e4352f299 100644
> --- a/arch/arm64/boot/dts/qcom/sdm845-db845c.dts
> +++ b/arch/arm64/boot/dts/qcom/sdm845-db845c.dts
> @@ -979,7 +979,7 @@ sdc2_card_det_n: sd-card-det-n {
> };
>
> wcd_intr_default: wcd_intr_default {
> - pins = <54>;
> + pins = "gpio54";
> function = "gpio";
>
> input-enable;