Re: [PATCH 1/2] platform/x86: simatic-ipc: correct name of a model

From: Henning Schild
Date: Thu Dec 22 2022 - 09:04:58 EST


Am Thu, 22 Dec 2022 14:44:18 +0200
schrieb Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>:

> On Thu, Dec 22, 2022 at 11:37:19AM +0100, Henning Schild wrote:
> > What we called IPC427G should be renamed to BX-39A to be more in
> > line with the actual product name.
>
> Can you tell what does the current name mean?

427G is an internal prototype name using the naming scheme that these
kind of machines used to use for several generations. For some reason
the naming scheme was changed and the public product name is BX-39A.

Please do not ask me why. But if you would happen to own such a device
you would know it as BX-39A _only_.

> Depending on that I would consider either your approach here or
> perhaps just adding a comment in each of the places.

Mentioning the name 427G, even as a comment, does not make much sense.
Since the box is for sale it is called BX-39A and was never called 427G.

I used the internal prototype name and only recently learned that never
became the final name. And this cleanup makes sure nobody gets
confused.

Henning