Re: [RFC PATCH 4/7] dt-bindings: bus: add STM32MP13 ETZPC firewall bus bindings

[Gatien CHEVALLIER]

Hello,

On 12/22/22 11:26, Krzysztof Kozlowski wrote:
> On 21/12/2022 18:30, Gatien Chevallier wrote:
> > Adds the list of peripherals IDs under firewall bus on STM32MP13.
> >
> > Signed-off-by: Gatien Chevallier <gatien.chevallier@xxxxxxxxxxx>
> > ---
> >   include/dt-bindings/bus/stm32mp13_sys_bus.h | 60 +++++++++++++++++++++
> >   1 file changed, 60 insertions(+)
> >   create mode 100644 include/dt-bindings/bus/stm32mp13_sys_bus.h
> >
> > diff --git a/include/dt-bindings/bus/stm32mp13_sys_bus.h b/include/dt-bindings/bus/stm32mp13_sys_bus.h
> > new file mode 100644
> > index 000000000000..1160de87bc4a
> > --- /dev/null
> > +++ b/include/dt-bindings/bus/stm32mp13_sys_bus.h
> > @@ -0,0 +1,60 @@
> > +/* SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) */
> > +/*
> > + * Copyright (C) STMicroelectronics 2022 - All Rights Reserved
> > + */
> > +#ifndef _DT_BINDINGS_BUS_STM32MP13_SYS_BUS_H
> > +#define _DT_BINDINGS_BUS_STM32MP13_SYS_BUS_H
> > +
> > +/* ETZPC IDs */
> > +#define STM32MP1_ETZPC_VREFBUF_ID	0
> > +#define STM32MP1_ETZPC_LPTIM2_ID	1
> > +#define STM32MP1_ETZPC_LPTIM3_ID	2
> > +#define STM32MP1_ETZPC_LTDC_ID		3
> > +#define STM32MP1_ETZPC_DCMIPP_ID	4
> > +#define STM32MP1_ETZPC_USBPHYCTRL_ID	5
> > +#define STM32MP1_ETZPC_DDRCTRLPHY_ID	6
> > +/* IDs 7-11 reserved */
> > +#define STM32MP1_ETZPC_IWDG1_ID		12
> > +#define STM32MP1_ETZPC_STGENC_ID	13
> > +/* IDs 14-15 reserved */
> > +#define STM32MP1_ETZPC_USART1_ID	16
> > +#define STM32MP1_ETZPC_USART2_ID	17
> > +#define STM32MP1_ETZPC_SPI4_ID		18
> > +#define STM32MP1_ETZPC_SPI5_ID		19
> > +#define STM32MP1_ETZPC_I2C3_ID		20
> > +#define STM32MP1_ETZPC_I2C4_ID		21
> > +#define STM32MP1_ETZPC_I2C5_ID		22
> > +#define STM32MP1_ETZPC_TIM12_ID		23
> > +#define STM32MP1_ETZPC_TIM13_ID		24
> > +#define STM32MP1_ETZPC_TIM14_ID		25
> > +#define STM32MP1_ETZPC_TIM15_ID		26
> > +#define STM32MP1_ETZPC_TIM16_ID		27
> > +#define STM32MP1_ETZPC_TIM17_ID		28
> > +/* IDs 29-31 reserved */
>
> Same comments (all of them). IDs cannot be reserved.

My response on patch [RFC PATCH 4/7] applies to this as well

> Best regards,
> Krzysztof

Best regards,
Gatien